Skip to content

Add six to requirements#101

Merged
rahulporuri merged 2 commits into
masterfrom
update-dependencies
Oct 9, 2019
Merged

Add six to requirements#101
rahulporuri merged 2 commits into
masterfrom
update-dependencies

Conversation

@rahulporuri
Copy link
Copy Markdown
Contributor

@rahulporuri rahulporuri commented Oct 9, 2019

six is now a runtime requirement because we removed the use of 2to3 in the package.
~ numpy and pandas have been runtime requirements of a few submodules of apptools which were never reported.~

	modified:   apptools/__init__.py
@codecov-io
Copy link
Copy Markdown

codecov-io commented Oct 9, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@a36dc9a). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #101   +/-   ##
=========================================
  Coverage          ?   41.68%           
=========================================
  Files             ?      240           
  Lines             ?     8912           
  Branches          ?     1158           
=========================================
  Hits              ?     3715           
  Misses            ?     5045           
  Partials          ?      152
Impacted Files Coverage Δ
apptools/__init__.py 60% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a36dc9a...c1d3034. Read the comment docs.

@corranwebster
Copy link
Copy Markdown
Contributor

Strong recommendation that Pandas is not a runtime requirement but an optional requirement instead (not sure what exactly requires it, but we don't want people having to install by default).

@rahulporuri
Copy link
Copy Markdown
Contributor Author

Strong recommendation that Pandas is not a runtime requirement but an optional requirement instead (not sure what exactly requires it, but we don't want people having to install by default).

yep yep. exactly @mdickinson 's concerns as well.
updating.

	modified:   apptools/__init__.py
@rahulporuri rahulporuri changed the title Add six, numpy and pandas to requirements Add six to requirements Oct 9, 2019
Copy link
Copy Markdown
Member

@mdickinson mdickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rahulporuri rahulporuri merged commit 159b78d into master Oct 9, 2019
@rahulporuri rahulporuri deleted the update-dependencies branch October 9, 2019 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants