Add long_description_content_type in setup.py#108
Merged
Conversation
which was missing from setup.py modified: setup.py
mdickinson
approved these changes
Oct 10, 2019
Member
mdickinson
left a comment
mdickinson
left a comment
There was a problem hiding this comment.
LGTM
twine check is working for me (twine version 2.0.0)
mirzakhani:apptools mdickinson$ twine check dist/apptools-4.5.0.dev63.tar.gz
Checking dist/apptools-4.5.0.dev63.tar.gz: PASSED
Codecov Report
@@ Coverage Diff @@
## master #108 +/- ##
==========================================
+ Coverage 41.67% 41.68% +0.01%
==========================================
Files 240 240
Lines 8912 8912
Branches 1105 1105
==========================================
+ Hits 3714 3715 +1
Misses 5044 5044
+ Partials 154 153 -1
Continue to review full report at Codecov.
|
mdickinson
pushed a commit
that referenced
this pull request
Oct 10, 2019
* FIX : Add long_description_content_type which was missing from setup.py modified: setup.py * Add changelog entry. (cherry picked from commit 0b745d0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
twine checkwas unhappy because of the missinglong_description_content_typekwarg tosetuptools.setup. This PR fixes that issue.Weirdly enough, even after adding this kwarg,
twine checkis still unhappy because of a bug upstream intwine.