Fix SyntaxWarning in file_path.py#116
Merged
Merged
Conversation
Fixes this SyntaxWarning: /usr/lib/python3/dist-packages/apptools/persistence/file_path.py:70: SyntaxWarni ng: "is not" with a literal. Did you mean "!="? if os.sep is not '/':
Codecov Report
@@ Coverage Diff @@
## master #116 +/- ##
=========================================
+ Coverage 41.67% 41.7% +0.02%
=========================================
Files 240 240
Lines 8912 8908 -4
Branches 1105 1154 +49
=========================================
+ Hits 3714 3715 +1
+ Misses 5044 5042 -2
+ Partials 154 151 -3
Continue to review full report at Codecov.
|
rahulporuri
approved these changes
Dec 31, 2019
Contributor
rahulporuri
left a comment
rahulporuri
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the fix!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes this SyntaxWarning:
/usr/lib/python3/dist-packages/apptools/persistence/file_path.py:70: SyntaxWarni
ng: "is not" with a literal. Did you mean "!="?
if os.sep is not '/':