Replace uses of the Unicode trait with Str#123
Conversation
|
I was jumping the gun a bit here. We can't do this until after we've dropped Python 2 support. |
|
This PR is ready to go in now because the upcoming release will not support Python 2. |
Codecov Report
@@ Coverage Diff @@
## master #123 +/- ##
==========================================
- Coverage 41.67% 40.13% -1.54%
==========================================
Files 240 240
Lines 8912 8909 -3
Branches 1105 1161 +56
==========================================
- Hits 3714 3576 -138
- Misses 5044 5189 +145
+ Partials 154 144 -10
Continue to review full report at Codecov.
|
I am not sure what sequence of events we are going after here for #120. |
|
I think we can merge this after #190 is merged (after fixing merge conflicts of course). |
|
I will be resolving the conflicts... |
| ratio = Float(1.0) | ||
| visible = Bool(True) | ||
| description = Unicode(u'description') | ||
| description = Str(u'description') |
There was a problem hiding this comment.
We could go further and drop the u prefixes, but that's probably best done in a separate PR.
mdickinson
left a comment
There was a problem hiding this comment.
@kitchoi Thank you for the changes! I can't officially approve because I opened the PR in the first place, but LGTM.
|
Thank you all! |
This PR replaces all uses of the deprecated
Unicodetrait type withStr.