Remove all checks for python version < 3 as we are dropping python2#201
Merged
Conversation
kitchoi
approved these changes
Nov 11, 2020
Contributor
kitchoi
left a comment
kitchoi
left a comment
There was a problem hiding this comment.
LGTM
(I am assuming this is not news-worthy for the end-users so there are no need for a news fragment)
rahulporuri
reviewed
Nov 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to #120
Since #190 has been merged and we intend to drop python 2 I believe it is fine to remove these checks now. The changes in this PR all occur in the
persistencesub package which right now, AFAIK, we plan on keeping.Additionally see here:
apptools/apptools/persistence/spickle.py
Lines 19 to 20 in a693c79
I left this for now as there is already a relevant issue open: #57
Checklist
- [ ] Add a news fragment if this PR is news-worthy for end users. (see docs/releases/README.rst)