Skip to content

Remove apptools.help subpackage and all references to it#215

Merged
aaronayres35 merged 3 commits into
masterfrom
remove-help
Nov 17, 2020
Merged

Remove apptools.help subpackage and all references to it#215
aaronayres35 merged 3 commits into
masterfrom
remove-help

Conversation

@aaronayres35
Copy link
Copy Markdown
Contributor

@aaronayres35 aaronayres35 commented Nov 16, 2020

closes #142

This PR removes the help sub-package and any references to it in apptools. Note that no other code in apptools was using it. logger was trying to use apptools.help.IHelp but that did not exist. The function referring toapptools.help.IHelp was actually never called anywhere else in logger, so that function was simply deleted.

Checklist

  • Add a news fragment if this PR is news-worthy for end users. (see docs/releases/README.rst)

Copy link
Copy Markdown
Contributor

@rahulporuri rahulporuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aaronayres35 aaronayres35 merged commit c2b701b into master Nov 17, 2020
@aaronayres35 aaronayres35 deleted the remove-help branch November 17, 2020 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Decide fate of apptools.help

2 participants