More Flake8 cleanup#229
Conversation
This reverts commit b1db042.
| # is relative to the documentation root, use os.path.abspath to make it | ||
| # absolute, like shown here. | ||
| #sys.path.append(os.path.abspath('some/directory')) | ||
| # sys.path.append(os.path.abspath('some/directory')) |
There was a problem hiding this comment.
I should probably just delete all these commented out code blocks
There was a problem hiding this comment.
Actually I'm not sure, some of it isn't really dead code, but rather unused options. I removed all of it in the latest commit, but if these should be kept I can simply revert that commit
| @@ -17,11 +17,11 @@ def __init__(self, firstname, lastname): | |||
| class Foo: | |||
There was a problem hiding this comment.
TBH these integration tests could probably just be deleted. I don't believe they ever get run/can be run
There was a problem hiding this comment.
There might be values in converting them to test cases so that they can be discovered and run? In any case, that would be a separate issue. Agreed that tests don't get automatically run typically get forgotten and end up bring broken long before anyone realizes.
There was a problem hiding this comment.
Yeah that makes sense. I will leave that for a separate issue/PR
| if six.PY3: | ||
| file.write(self.get_code()) | ||
| else: | ||
| file.write(six.text_type(self.get_code(), encoding="utf-8")) |
There was a problem hiding this comment.
This change is not a flake8 cleaning, it is just related to dropping pyhton 2 support #120
I added it because the later case below with six.PY2 had a flake8 error, so I removed it, and it felt appropriate to remove them together.
There was a problem hiding this comment.
This sparked my opening of #230 which makes the same change, but goes further to replace all uses of six throughout the code base.
3 participants
part of #145
With this PR the codebase is very nearly fully flake8 clean. There is the possibility some of the remaining non-flake8 clean code will be killed as well.
Checklist
- [ ] Add a news fragment if this PR is news-worthy for end users. (see docs/releases/README.rst)