Remove apptools.naming.ui submodule#233
Merged
Merged
Conversation
rahulporuri
reviewed
Nov 24, 2020
Contributor
rahulporuri
left a comment
rahulporuri
left a comment
There was a problem hiding this comment.
Mostly LGTM. There are a couple of comments and there is a naming/explorer example that will also need to be removed.
Co-authored-by: Poruri Sai Rahul <rporuri@enthought.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned here: #146 (comment), it has been decided that we will remove the
apptools.naming.uisubmodule. This PR simple deletes the submodule and any reference to it.Note I deleted images from the
LICENSE.txtfile as the modules containing them have now been deleted. It seems to me that should be okay to do.Checklist