Backports for 5.0.0 and update Changelog#263
Merged
Merged
Conversation
* make sure optional dependencies are optional for tests * add a news fragment * apply suggestion from code review
* add optional dependencies for specific cub packages to extras_require * add details to README about optional dependencies * list io imports as standard library imports * add prefrences/configobj to extras_rrequire as well (leave configobj in install_requires too) * add specific install instructions * formatting * remove unneeded back ticks * move install instructions into a separate section * add news fragment * add PR number to news fragment
* remove image license files * move internal image license file to root directory * add image_LICENSE_CP.txt and include it in manifest * Apply suggestions from code review Co-authored-by: Poruri Sai Rahul <rporuri@enthought.com> Co-authored-by: Poruri Sai Rahul <rporuri@enthought.com>
aaronayres35
commented
Dec 16, 2020
| Test suite | ||
| ---------- | ||
| * Fix AttributeError on Python 3.9 due to usage of ``base64.decodestring`` in tests (#210) | ||
| * Make optional dependencies optional for tests (#260) |
Contributor
Author
There was a problem hiding this comment.
One thing I noticed in this PR (it very well may have already been pointed out, I can't remember), is that with the new news fragment system PRs are added to the changelog in order of lowest to highest PR number, which may differ from other ets changelogs.
Not saying anything needs to change, just an observation
Contributor
There was a problem hiding this comment.
Ahh. Good point. Not anything we need to change though.
aaronayres35
added a commit
that referenced
this pull request
Dec 17, 2020
* Make sure optional dependencies are optional for tests (#260) * make sure optional dependencies are optional for tests * add a news fragment * apply suggestion from code review * Add extras_require to setup.py for optional dependencies (#257) * add optional dependencies for specific cub packages to extras_require * add details to README about optional dependencies * list io imports as standard library imports * add prefrences/configobj to extras_rrequire as well (leave configobj in install_requires too) * add specific install instructions * formatting * remove unneeded back ticks * move install instructions into a separate section * add news fragment * add PR number to news fragment * Remove image license files (#262) * remove image license files * move internal image license file to root directory * add image_LICENSE_CP.txt and include it in manifest * Apply suggestions from code review Co-authored-by: Poruri Sai Rahul <rporuri@enthought.com> Co-authored-by: Poruri Sai Rahul <rporuri@enthought.com> * Add a new category for build system related changes (#261) * update changelog Co-authored-by: Poruri Sai Rahul <rporuri@enthought.com> Co-authored-by: Kit Choi <kitchoi@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Targeting maint/5.0]
This PR backports merged PRs to the 5.0 branch in preparation for the upcoming release. It also updates the changelog to include these backported PRs. Only the last commit which updates the changelog needs to be reviewed (the others have been reviewed already).
Checklist
- [ ] Add a news fragment if this PR is news-worthy for end users. (see docs/releases/README.rst)