Skip to content

Add docstrings to api modules in apptools subpackages#274

Merged
rahulporuri merged 3 commits into
masterfrom
doc/docstrings-in-api-modules
Jan 11, 2021
Merged

Add docstrings to api modules in apptools subpackages#274
rahulporuri merged 3 commits into
masterfrom
doc/docstrings-in-api-modules

Conversation

@rahulporuri
Copy link
Copy Markdown
Contributor

@rahulporuri rahulporuri commented Jan 11, 2021

This PR adds module docstrings to all api modules in the various apptools subpackages.

Checklist

  • Add a news fragment if this PR is news-worthy for end users. (see docs/releases/README.rst)

Sai Rahul Poruri added 2 commits January 11, 2021 12:15
	modified:   apptools/io/api.py
	modified:   apptools/logger/api.py
	modified:   apptools/naming/api.py
	modified:   apptools/naming/trait_defs/api.py
	modified:   apptools/preferences/api.py
	modified:   apptools/preferences/ui/api.py
	modified:   apptools/scripting/api.py
	modified:   apptools/selection/api.py
	modified:   apptools/type_registry/api.py
	modified:   apptools/undo/action/api.py
	modified:   apptools/undo/api.py
	new file:   docs/releases/upcoming/274.doc.rst
Copy link
Copy Markdown
Contributor

@aaronayres35 aaronayres35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM

One thing I noticed though (This is probably already known), is that when you navigate to the page for one of the api modules rather than just seeing links to the docs for the objects you get the api docs directly on that page. In other words, the full contents for the docs of the apptools.naming package are on one page. Consider this example from envisage:
Screen Shot 2021-01-11 at 8 07 58 AM

Whereas in apptools we have:
Screen Shot 2021-01-11 at 8 09 27 AM
Notice the section for apptools.naming.binding module at the bottom of the screenshot. There are sections for the other naming submodules as well all on this same page.

This may be intentional / unrelated to the changes of this PR so feel free to ignore, but I wanted to make sure it was pointed out

@rahulporuri
Copy link
Copy Markdown
Contributor Author

This may be intentional / unrelated to the changes of this PR so feel free to ignore, but I wanted to make sure it was pointed out

Yup. This is because of the recent change where we use templates when building docs.

@rahulporuri rahulporuri merged commit 5e55c08 into master Jan 11, 2021
@rahulporuri rahulporuri deleted the doc/docstrings-in-api-modules branch January 11, 2021 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants