Skip to content

Replace use of envisage "contributes_to" decorator in docs#286

Merged
rahulporuri merged 1 commit into
masterfrom
rahulporuri-patch-1
Apr 16, 2021
Merged

Replace use of envisage "contributes_to" decorator in docs#286
rahulporuri merged 1 commit into
masterfrom
rahulporuri-patch-1

Conversation

@rahulporuri
Copy link
Copy Markdown
Contributor

This PR removes the use of envisage @contributes_to decorator in favor of a trait List with metadata contributes_to instead. This is being done because the next release of envisage removes the decorator entirely. Ref enthought/envisage#402

with a trait with metadata `contributes_to`
Copy link
Copy Markdown
Contributor

@aaronayres35 aaronayres35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Orthogonal to this PR, but this files existence entirely is a bit out of place. There are preferences docs in the envisage docs that we likely want to merge with this (https://docs.enthought.com/envisage/envisage_core_documentation/preferences.html)

@rahulporuri
Copy link
Copy Markdown
Contributor Author

Orthogonal to this PR, but this files existence entirely is a bit out of place. There are preferences docs in the envisage docs that we likely want to merge with this (https://docs.enthought.com/envisage/envisage_core_documentation/preferences.html)

You're right. These docs do probably belong in envsiage, not in apptools.

@rahulporuri rahulporuri merged commit 96c3af4 into master Apr 16, 2021
@rahulporuri rahulporuri deleted the rahulporuri-patch-1 branch April 16, 2021 12:57
@rahulporuri
Copy link
Copy Markdown
Contributor Author

created enthought/envisage#403

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants