Replace Property depends_on with observe#289
Merged
Merged
Conversation
Contributor
Author
|
Agh, I forgot a news fragment. I will open a separate PR. |
Contributor
|
@aaronayres35 dunno if this is worth a news fragment - well maybe a news fragment mentioning that we now explicitly depend on traits >= 6.2.0. |
Contributor
Author
I guess that is true, we have had changelog entries for otc-> observe changes in other packages, but they typically contain a list of all PRs involved, eg depends_on, dynamic and static handlers, _name_changed, etc. I guess I will just close #290 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note these changes now make
apptoolsrequire traits >= 6.2.I checked to specify this requirement, but it appears as though traits isn't even explicitly listed as a requirement, but rather is implicitly required throughEDIT: I've addedtraitsui(which now explicitly requires traits >= 6.2).traits>=6.2.0as an explicit required dependency on this PR.apptools/setup.py
Lines 305 to 308 in 96c3af4
Checklist