Replace eval with ast.literal_eval in apptools.preferences#299
Merged
Conversation
We don't need the full power of eval() here, literal_eval() should do everything we need, is safer, and anything which breaks can be modified to use a custom trait that is more focused.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't need the full power of
eval()here,literal_eval()should do everything we need, is safer, and anything which breaks can be modified to use a custom trait that is more focused. This change doesn't break any existing tests, but includes a new test that something which should fail due to the change, does.Checklist