Update etstool for use with Python 3.8#316
Merged
Merged
Conversation
Member
Author
|
(successful) ets-from-source run on this branch: https://github.com/enthought/apptools/actions/runs/2860939442 |
corranwebster
approved these changes
Aug 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates
etstool.pyand the EDM-based test workflow to support Python 3.8 as well as Python 3.6.The
etstool.pychanges ended up being more extensive than I originally intended, since I ran into issues with using a non-EDM Python as a bootstrap environment on Windows. So there's now some additional logic to identify the EDM executable on Windows, overridable through a command-line argument or an environment variable. (This logic was copied from other similar workflows, like the one in Envisage.)Checklist