Skip to content

Fix state pickler for Python 3.11 #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mdickinson merged 5 commits into from
Feb 8, 2023
Merged

Fix state pickler for Python 3.11 #328

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
80345d4
Fix state pickler for Python 3.11
mdickinson Feb 7, 2023
ae8eab6
Add news entry
mdickinson Feb 7, 2023
85b03fc
Add 3.11 to test versions in GitHub Actions workflow
mdickinson Feb 7, 2023
d5bda58
Merge branch 'main' into fix-state-pickler-for-311
mdickinson Feb 8, 2023
3e0cc39
Fix syntax error in workflow
mdickinson Feb 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test-with-pip.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest, windows-latest, macos-latest]
python-version: ['3.7', '3.8', '3.9', '3.10']
python-version: ['3.7', '3.8', '3.9', '3.10', '3.11']

runs-on: ${{ matrix.os }}

Expand Down
5 changes: 4 additions & 1 deletion apptools/persistence/state_pickler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,11 +393,14 @@ def _do_instance(self, value):
args = value.__getinitargs__()

# Get the object state.
state = None
if hasattr(value, "__get_pure_state__"):
state = value.__get_pure_state__()
elif hasattr(value, "__getstate__"):
# Note that __getstate__() may return None in Python >= 3.11
state = value.__getstate__()
else:

if state is None:
state = value.__dict__

state.pop("__traits_version__", None)
Expand Down
1 change: 1 addition & 0 deletions docs/releases/upcoming/328.bugfix.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix StatePickler for Python 3.11. (#328)