-
Notifications
You must be signed in to change notification settings - Fork 21
Drop Python 3.7 support and fix test workflows #339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
179a09c
Drop 3.7 from test workflows
mdickinson 8464f7f
Add news entry
mdickinson 369a083
Avoid running on Apple Silicon - pytables is not installable there
mdickinson e9559b8
Restrict version of NumPy, which conflicts with the most recent relea…
mdickinson e5a35c9
Be consistent about numpy versions
mdickinson b4a4703
Merge branch 'main' into dev/drop-python37
mdickinson bd1a99d
Drop support for Python 3.6 in etstool.py
mdickinson 50838f6
Merge remote-tracking branch 'origin/dev/drop-python37' into dev/drop…
mdickinson 81b52ed
Experiment: attempt to run tests on EDM Python 3.11
mdickinson 014be0a
Add dependabot config
mdickinson 999df0c
Update EDM version in workflows
mdickinson de8e08b
Use rh8-x8_64 for Python 3.11
mdickinson e644db2
Don't include Sphinx or the Enthought Sphinx Theme on Python 3.11
mdickinson 90231f0
Fix missing return
mdickinson 1bf139b
Move flake8_ets out of depenencies on 3.11
mdickinson a760bc9
Streamline dependency calculation
mdickinson aa9ec79
Move flake8 into 3.8-only dependencies
mdickinson 69bc850
Only run style checks on 3.8
mdickinson c7d98c6
Fixing comments
mdickinson 88841ad
Go back to Apple Silicon, but don't install pytables there
mdickinson b873a4f
Add issue references
mdickinson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| version: 2 | ||
| updates: | ||
| - package-ecosystem: "github-actions" | ||
| directory: "/" | ||
| schedule: | ||
| interval: "weekly" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Drop support for Python 3.7. (#339) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, just for context, I see that we don't have any CI jobs that build documentation, so are we using Sphinx anywhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We use Sphinx to build docs after making a release, and the current workflow for that is to do it manually via etstool.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed that we should ideally have a workflow for that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, thanks!