Make TraitsUI, Pyface and configobj optional dependencies#351
Conversation
flongford
left a comment
There was a problem hiding this comment.
Generally LGTM - just a couple of comments on the scope of this issue.
I presume that these updated dependencies will be propagated through to our "publish on pip" GH actions workflow without further changes required. Do we have any "publish on EDS" equivalent workflows (automated or manual) that need to be updated post-merge?
Yes - the
We don't: the "publish on EDS" workflow is entirely manual (I go and fill out a build request). So that build request will include a note that the requirements have changed. |
Apptools contains several disparate packages with different needs. While it's somewhat reasonable to regard Traits as a core dependency, not all subpackages need a GUI, and only the preferences package makes use of configobj.
This PR:
extras_requireinsetup.pyCloses #70
Makes #86 obsolete.
Checklist