Fix state_pickler.dump in py2#61
Merged
Merged
Conversation
Member
|
@kitchoi -- thanks! Do all the mayavi tests pass with this change? |
Contributor
Author
|
@prabhuramachandran Yes tests for mayavi pass. |
Member
|
Thanks, merging! |
prabhuramachandran
added a commit
that referenced
this pull request
Mar 17, 2016
Fix state_pickler.dump in py2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Python2 environment,
state_pickler.dump(obj, u'file.path')would raise an Error, but it is not necessary to do further type checking asopenalready handles that for us.@prabhuramachandran can you take a look please? This problem arises when trying Save/Load visualization in Mayavi2 in Python2.7 environment.