Skip to content

FIX: Fix for NumPy deprecation#83

Merged
mdickinson merged 1 commit into
enthought:masterfrom
larsoner:np-dep
Jan 24, 2019
Merged

FIX: Fix for NumPy deprecation#83
mdickinson merged 1 commit into
enthought:masterfrom
larsoner:np-dep

Conversation

@larsoner
Copy link
Copy Markdown
Contributor

@larsoner larsoner commented Jan 23, 2019

Following the suggestion from:

  /home/larsoner/python/apptools/build/lib/apptools/persistence/state_pickler.py:661: DeprecationWarning: np.loads is deprecated, use pickle.loads instead
    result = numpy.loads(junk, encoding='bytes')

@mdickinson
Copy link
Copy Markdown
Member

mdickinson commented Jan 24, 2019

LGTM. Thank you!

@mdickinson mdickinson merged commit af64aaf into enthought:master Jan 24, 2019
@mdickinson
Copy link
Copy Markdown
Member

mdickinson commented Jan 24, 2019

FWIW, here's the current source of numpy.loads, making it clear that pickle.loads is a drop-in replacement: https://github.com/numpy/numpy/blob/a5cace49b79690795df29c6da3587e7a45a41591/numpy/lib/npyio.py#L38-L44

@larsoner larsoner deleted the np-dep branch January 24, 2019 13:10
@rahulporuri rahulporuri mentioned this pull request Oct 9, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdickinson mdickinson mdickinson approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@larsoner @mdickinson