Use etstool utility#92
Conversation
|
The travis CI failure is |
|
i'm not sure why we don't see this failure in #90 |
|
What's more interesting is the fact that this failure is only seen on the linux travis jobs, not on the osx travis jobs. I feel like i'm missing something obvious here. |
useful click commands are - install - test - test-clean - test-all new file: ci-src-requirements.txt new file: etstool.py
and use edm to setup the environment modified: .travis.yml new file: install-edm-linux.sh new file: install-edm-osx.sh
new file: appveyor.yml new file: install-edm-windows.cmd
modified: .travis.yml modified: appveyor.yml
e3cebb5 to
b7af310
Compare
|
sigh. i'm not sure what's going on with the CI. all of the linux jobs failed with the following error - which is also the error i saw in #92 |
modified: .travis.yml
modified: etstool.py
modified: .travis.yml
|
The test failure is a direct consequence of running the tests from a directory that's under We can fix the test, or we can run the tests from a newly-created empty directory in the repository instead of running from a temporary directory. The former would be better (obviously). |
mdickinson
left a comment
There was a problem hiding this comment.
LGTM. The test failure should (?) be fixed by merging in #104.
Codecov Report
@@ Coverage Diff @@
## master #92 +/- ##
=========================================
Coverage ? 41.66%
=========================================
Files ? 240
Lines ? 8912
Branches ? 1105
=========================================
Hits ? 3713
Misses ? 5045
Partials ? 154Continue to review full report at Codecov.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #92 +/- ##
=========================================
Coverage ? 41.66%
=========================================
Files ? 240
Lines ? 8912
Branches ? 1105
=========================================
Hits ? 3713
Misses ? 5045
Partials ? 154 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
NOTE : The base branch for this PR is #90The
etstoolutility module is used to setup the environments and test the package. Travis was updated to use the utility module when installing and testing the package. Note that we are now testing the package on OSX along with linux.