Skip to content

Use etstool utility#92

Merged
rahulporuri merged 8 commits into
masterfrom
ci/use-etstool-util
Oct 9, 2019
Merged

Use etstool utility#92
rahulporuri merged 8 commits into
masterfrom
ci/use-etstool-util

Conversation

@rahulporuri
Copy link
Copy Markdown
Contributor

@rahulporuri rahulporuri commented May 18, 2019

NOTE : The base branch for this PR is #90

The etstool utility module is used to setup the environments and test the package. Travis was updated to use the utility module when installing and testing the package. Note that we are now testing the package on OSX along with linux.

@rahulporuri
Copy link
Copy Markdown
Contributor Author

The travis CI failure is

======================================================================
FAIL: Test if relative paths are set correctly.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/build/enthought/apptools/apptools/persistence/tests/test_file_path.py", line 48, in test_relative
    self.assertEqual(f.rel_pth, expect)
AssertionError: 'tmpAO5BM4/data/t.vtk' != '../tmp/tmpAO5BM4/data/t.vtk'
----------------------------------------------------------------------

@rahulporuri
Copy link
Copy Markdown
Contributor Author

i'm not sure why we don't see this failure in #90

@rahulporuri
Copy link
Copy Markdown
Contributor Author

What's more interesting is the fact that this failure is only seen on the linux travis jobs, not on the osx travis jobs. I feel like i'm missing something obvious here.

@rahulporuri rahulporuri changed the base branch from feat/remove-2to3 to master May 29, 2019 09:57
Poruri Sai Rahul added 4 commits May 29, 2019 15:28
useful click commands are
- install
- test
- test-clean
- test-all

	new file:   ci-src-requirements.txt
	new file:   etstool.py
and use edm to setup the environment

	modified:   .travis.yml
	new file:   install-edm-linux.sh
	new file:   install-edm-osx.sh
	new file:   appveyor.yml
	new file:   install-edm-windows.cmd
	modified:   .travis.yml
	modified:   appveyor.yml
@rahulporuri rahulporuri force-pushed the ci/use-etstool-util branch from e3cebb5 to b7af310 Compare May 29, 2019 09:58
@rahulporuri
Copy link
Copy Markdown
Contributor Author

sigh. i'm not sure what's going on with the CI. all of the linux jobs failed with the following error -

======================================================================

FAIL: Test if relative paths are set correctly.

----------------------------------------------------------------------

Traceback (most recent call last):

  File "/home/travis/build/enthought/apptools/apptools/persistence/tests/test_file_path.py", line 48, in test_relative

    self.assertEqual(f.rel_pth, expect)

AssertionError: 'tmpaEZMUG/data/t.vtk' != '../tmp/tmpaEZMUG/data/t.vtk'

----------------------------------------------------------------------

which is also the error i saw in #92

poruri sai rahul added 3 commits October 9, 2019 14:57
	modified:   etstool.py
	modified:   .travis.yml
@mdickinson
Copy link
Copy Markdown
Member

The test failure is a direct consequence of running the tests from a directory that's under /tmp.

We can fix the test, or we can run the tests from a newly-created empty directory in the repository instead of running from a temporary directory. The former would be better (obviously).

Copy link
Copy Markdown
Member

@mdickinson mdickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The test failure should (?) be fixed by merging in #104.

@codecov-io
Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (master@a06a6da). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #92   +/-   ##
=========================================
  Coverage          ?   41.66%           
=========================================
  Files             ?      240           
  Lines             ?     8912           
  Branches          ?     1105           
=========================================
  Hits              ?     3713           
  Misses            ?     5045           
  Partials          ?      154

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a06a6da...0055876. Read the comment docs.

@rahulporuri rahulporuri merged commit abaf5d4 into master Oct 9, 2019
@rahulporuri rahulporuri deleted the ci/use-etstool-util branch October 9, 2019 16:42
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (master@a06a6da). Learn more about missing BASE report.

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #92   +/-   ##
=========================================
  Coverage          ?   41.66%           
=========================================
  Files             ?      240           
  Lines             ?     8912           
  Branches          ?     1105           
=========================================
  Hits              ?     3713           
  Misses            ?     5045           
  Partials          ?      154           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants