Improve tests for AbstractDataSource subclasses#244
Conversation
corranwebster
changed the title
|
Changes Unknown when pulling 3714bd5 on enh/data-source-tests into * on master*. |
|
Changes Unknown when pulling d9ba227 on enh/data-source-tests into * on master*. |
|
Changes Unknown when pulling 8bfa702 on enh/data-source-tests into * on master*. |
|
Changes Unknown when pulling 6edd34e on enh/data-source-tests into * on master*. |
|
Changes Unknown when pulling 262c2bc on enh/data-source-tests into * on master*. |
|
Changes Unknown when pulling ffa0e9e on enh/data-source-tests into * on master*. |
1 similar comment
|
Changes Unknown when pulling ffa0e9e on enh/data-source-tests into * on master*. |
|
@corranwebster you might want to look at the https://github.com/enthought/enable travis-ci setup to get all the necessary dependencies. |
|
@itziakos Ah - the problem isn't that they aren't there, it's that PIL can't find them. Can we shift enable etc. to depend on Pillow? |
|
Changes Unknown when pulling 6eeb229 on enh/data-source-tests into * on master*. |
I think @jwiggins might have more info on that. |
|
Changes Unknown when pulling 530f2bb on enh/data-source-tests into * on master*. |
|
We have to wait until there's a straightforward upgrade path for Canopy. I believe this will require "real" dependency support which is currently planned for enpkg. |
|
Changes Unknown when pulling 0479ba4 on enh/data-source-tests into * on master*. |
There was a problem hiding this comment.
Again, I would replace that comment by another ticket. And I agree with you it should be changed.
|
This is awesome. Thanks for taking the time. Many tests could be less verbose with a |
|
OK I think everything is addressed. Assuming tests pass, this should be good for merge. @jonathanrocher you might want to give it a once-over check. |
|
Changes Unknown when pulling 6ba47ec on enh/data-source-tests into * on master*. |
|
Will look at it. Could you resolve the conflict? |
Conflicts: MANIFEST.in
|
Done - it was in the new manifest file, so tests should pass fine. |
|
Changes Unknown when pulling 1a998ed on enh/data-source-tests into * on master*. |
Conflicts: CHANGES.txt
|
Changes Unknown when pulling d734ef3 on enh/data-source-tests into * on master*. |
|
Just took the liberty to push a couple of lines to add details to the CHANGES.txt. LGTM. Merging. Thanks @corranwebster ! |
Improve tests for AbstractDataSource subclasses
|
Changes Unknown when pulling 99bea26 on enh/data-source-tests into * on master*. |
5 participants
These are fairly basic objects with almost no tests, and tests should be straightforward.