Use ArrayOrNone#350
Conversation
cfarrow
left a comment
cfarrow
left a comment
There was a problem hiding this comment.
Sorry for being pedantic about the comments. I'm teaching this week. :)
Other than these comments and the test failure, LGTM.
| @@ -133,7 +133,7 @@ class RangeSelection(AbstractController): | |||
|
|
|||
| # The data space start and end coordinates of the selected region, | |||
| # expressed as a list. | |||
|
|
||
|
|
||
| class TestArrayOrNone(unittest.TestCase): | ||
| """ Test that the FutureWarning from numpy concerning comparison of arrays |
There was a problem hiding this comment.
It would be helpful to expand upon this to include the numpy version where this is a warning and the version where it will become an exception.
|
The test failure is on python 3.4 using qt4. It appears to be due to a setup issue with pyside (perhaps this). I've not looked deeper into it. |
|
@cfarrow The remaining failures seem to be general problems with the Travis setup. |
|
Yes. The test failures look unrelated. We can deal with them elsewhere. |
|
LGTM |
|
Note that the last change to get this working with Enable's |
|
The next Chaco release will require an Enable release. I'm not too worried about that. Still LGTM |
2 participants
Fixes all of the instances of
FutureWarning: comparison to `None` will result in an elementwise object comparison in the future.that I could find.Additionally clean up a few warnings so that we have a clean test suite.