FIX: Ensure contiguous inputs to points_in_polygon

[jwiggins]

Ahem... Right. So, in #409, I said there was one other call to points_in_polygon, but it looked OK. Well, I was wrong. It was being called with a transposed input. This corrects that.

[corranwebster]

Again, LGTM.

Although can we do this without the transpose by using a different numpy stacking operation?

[jwiggins]

Yes:

In [10]: arr = np.hstack((index[:, np.newaxis], value[:, np.newaxis]))

In [11]: arr
Out[11]: 
array([[ 0, 10],
       [ 1,  9],
       [ 2,  8],
       [ 3,  7],
       [ 4,  6],
       [ 5,  5],
       [ 6,  4],
       [ 7,  3],
       [ 8,  2],
       [ 9,  1]])

In [12]: arr.__array_interface__
Out[12]: 
{'data': (4302308880, False),
 'descr': [('', '<i8')],
 'shape': (10, 2),
 'strides': None,
 'typestr': '<i8',
 'version': 3}

In [13]: np.vstack((index, value)).T
Out[13]: 
array([[ 0, 10],
       [ 1,  9],
       [ 2,  8],
       [ 3,  7],
       [ 4,  6],
       [ 5,  5],
       [ 6,  4],
       [ 7,  3],
       [ 8,  2],
       [ 9,  1]])

[corranwebster]

Finally had a little bit of time to think about this and look things up: I think column_stack may be even better.

[jwiggins]

Indeed. New commit incoming along with a redo of the changes in #409

[corranwebster]

👍

[jwiggins]

Thanks for the input & review