Skip to content

FIX: do not render quiver if there is no point#424

Merged
ku-ya merged 2 commits into
enthought:masterfrom
ku-ya:fix/quiver-no-point
Aug 2, 2018
Merged

FIX: do not render quiver if there is no point#424
ku-ya merged 2 commits into
enthought:masterfrom
ku-ya:fix/quiver-no-point

Conversation

@ku-ya
Copy link
Copy Markdown
Contributor

@ku-ya ku-ya commented Jul 15, 2018

Do not render quiver if there are no points to draw.

Fixes #414

@ku-ya ku-ya requested a review from jvkersch July 15, 2018 17:31
Comment thread chaco/quiverplot.py Outdated

# Draw the body of the arrow
if len(points) < 1:
return
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this up to the top of the function. Then LGTM.

@ku-ya
Copy link
Copy Markdown
Contributor Author

ku-ya commented Jul 17, 2018

@rkern Thank you for the suggestion. It has been updated.

@corranwebster
Copy link
Copy Markdown
Contributor

LGTM

@ku-ya ku-ya merged commit c307b88 into enthought:master Aug 2, 2018
@ku-ya ku-ya deleted the fix/quiver-no-point branch August 2, 2018 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants