Fix float indices in Spectrum demo#427
Merged
Merged
Conversation
Fixes issue where NumPy doesn't accept float values to define shapes, to
index, or to slice by replacing the true divisions with floor divisions
(`//`) when dividing the number of samples by 2.
```python
Traceback (most recent call last):
File "spectrum.py", line 186, in <module>
popup = Demo()
File "spectrum.py", line 172, in __init__
self.plot = _create_plot_component(self.controller)
File "spectrum.py", line 41, in _create_plot_component
empty_amplitude = zeros(NUM_SAMPLES/2)
TypeError: 'float' object cannot be interpreted as an integer
```
|
I cannot test this on my system, but the changes LGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue where NumPy doesn't accept float values to define shapes, to index, or to slice by replacing the true divisions with floor divisions (
//) when dividing the number of samples by 2.