Update Cython generated code to support Python 3.7#433
Merged
corranwebster merged 1 commit intoApr 8, 2019
Merged
Conversation
Contributor
|
Thanks for the contribution. Is there any change to the .pyx files, or is this simply a regeneration of the .c files with a more recent Cython? |
Contributor
Author
|
No change to .pyx files was necessary, I was seeing build errors when trying to create a wheel for Python 3.7 and running a new Cython over the .pyx files solved the issue. Updated the PR description to reflect this! |
Contributor
|
Cool. Thanks for doing this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No change to .pyx files, just needed to updated the generated .c files with a more recent version of Cython (0.29.6) to support compiling with Python 3.7.