Skip to content

Refactor DataPrinter to add _build_text_from_event method#450

Merged
jonathanrocher merged 1 commit into
masterfrom
maint/refactor_dataprinter
Jun 12, 2019
Merged

Refactor DataPrinter to add _build_text_from_event method#450
jonathanrocher merged 1 commit into
masterfrom
maint/refactor_dataprinter

Conversation

@jonathanrocher
Copy link
Copy Markdown
Collaborator

@jonathanrocher jonathanrocher commented Jun 10, 2019

Goal is to mirror what was done in ImageInspectorOverlay in #431 for consistency and educational purposes.

(Few more tweaks to make the file pep8 compliant.)

Copy link
Copy Markdown
Contributor

@jvkersch jvkersch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonathanrocher
Copy link
Copy Markdown
Collaborator Author

Thanks for looking at this quickly! Merging...

@jonathanrocher jonathanrocher merged commit 6cedd85 into master Jun 12, 2019
@jonathanrocher jonathanrocher deleted the maint/refactor_dataprinter branch June 12, 2019 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants