Add rectangular selection tool#482
Merged
Merged
Conversation
Contributor
|
This looks good, and nicely done - a neat approach that I wouldn't have thought of to get this effect. I know that the superclass doesn't have any tests, but any chance for tests for this? |
corranwebster
approved these changes
Aug 27, 2019
Contributor
Author
Sure, I added a test to check for selecting the middle two of four co-linear points. |
Contributor
|
Thanks. LGTM. I'll leave it up to @jvkersch to manage the merge unless there is some urgency. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a subclass,
RectangularSelection, of theLassoSelectiontool that allows selection via a rectangular bounding box. This is a much quicker user interaction for situations where the selection region does not need to be as precise as the lasso tool allows or when the data being selected lie on a regular grid.This also adds (yet another!) scatter selection demo script, which augments the lasso selection demo: