Use Cython to build extension modules#502
Merged
Merged
Conversation
rahulporuri
approved these changes
Dec 31, 2019
Contributor
rahulporuri
left a comment
rahulporuri
left a comment
There was a problem hiding this comment.
LGTM except for a minor question.
| include chaco/tools/toolbars/images*.svg | ||
| include chaco/tools/toolbars/images*.txt | ||
| include chaco/layers/data/*.svg | ||
| recursive-include chaco *.pyx |
Contributor
There was a problem hiding this comment.
Am i missing something or should we be including the cntr.c file?
#459 was doing this.
Contributor
Author
There was a problem hiding this comment.
C files that are listed in extension modules are included by default (https://packaging.python.org/guides/using-manifest-in/). I missed that in #459.
Contributor
|
can you also update the PR description with a ref to the issue that this PR addresses? |
Contributor
Author
|
Done and done. Thanks @rahulporuri for the quick review. Happy to enter a new decade of Python hacking with you 🎉 🎆 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the autogenerated .c files and relies on Cython being present at build time to build the extension modules.
Supersedes #459
Fixes #333