Fix: Zoom not working with contour plots#506
Merged
Merged
Conversation
shoeb-github
requested review from
corranwebster,
jvkersch and
jwiggins
and removed request for
jwiggins
midhun-pm
reviewed
Jan 2, 2020
Comment on lines
+155
to
+156
| self.invalidate_draw() | ||
| self.request_redraw() |
Contributor
There was a problem hiding this comment.
Seems to work. Not sure what self.invalidate_draw() does as the zoom works even without it.
midhun-pm
approved these changes
Jan 2, 2020
added 2 commits
January 3, 2020 10:21
- because invalidation will require a redraw. By calling only invalidate_draw it is not clear that request_redraw would also be called eventually.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #466. Also reported in #359.
Fixed by requesting redraw when index mapper is updated in contour plots.