Skip to content

Fix and clean up multiaxis.py example#513

Merged
jonathanrocher merged 6 commits into
masterfrom
doc/add_multiaxis_axis_titles
Feb 18, 2020
Merged

Fix and clean up multiaxis.py example#513
jonathanrocher merged 6 commits into
masterfrom
doc/add_multiaxis_axis_titles

Conversation

@jonathanrocher
Copy link
Copy Markdown
Collaborator

@jonathanrocher jonathanrocher commented Feb 5, 2020

  • Aligned j0, j2 and j3's value_mapper so curves are correctly placed. To some extent, that changes a bit the purpose of the example to be more like the kind of thing that's scientifically useful (as opposed to disconnecting 4 plot's y mappers, but only displaying 2 axis).
  • Added axis titles to clarify where to read y-values.
  • Added a zoom tool because it is tricky to do and universally needed.
  • pep8 fixes.

@jonathanrocher jonathanrocher changed the title Example: improve multiaxis.py Fix and clean up multiaxis.py example Feb 6, 2020
Copy link
Copy Markdown
Contributor

@jvkersch jvkersch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jonathanrocher
Copy link
Copy Markdown
Collaborator Author

Thanks for the review! Merging...

@jonathanrocher jonathanrocher merged commit 54727c9 into master Feb 18, 2020
@jonathanrocher jonathanrocher deleted the doc/add_multiaxis_axis_titles branch February 18, 2020 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants