Skip to content

FIX: Enforce underscore for click command#523

Merged
ku-ya merged 1 commit into
masterfrom
fix/click-enforce-underscore
Jul 14, 2020
Merged

FIX: Enforce underscore for click command#523
ku-ya merged 1 commit into
masterfrom
fix/click-enforce-underscore

Conversation

@ku-ya
Copy link
Copy Markdown
Contributor

@ku-ya ku-ya commented Jul 11, 2020

Applying a quick fix for Command names with underscores must be invoked with dashes instead when upgrading from 6.7 to 7.0

This will make the documentation command consistent:

python edmtool.py test_all

@ku-ya ku-ya requested a review from jvkersch July 11, 2020 16:48
@mdickinson
Copy link
Copy Markdown
Member

Closing and re-opening to trigger new CI build (for reasons unrelated to this PR; sorry).

@mdickinson mdickinson closed this Jul 14, 2020
@mdickinson mdickinson reopened this Jul 14, 2020
Copy link
Copy Markdown
Contributor

@rahulporuri rahulporuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rahulporuri
Copy link
Copy Markdown
Contributor

xref same PR in traitsui enthought/traitsui#991.

@ku-ya ku-ya merged commit 3de7780 into master Jul 14, 2020
@ku-ya ku-ya deleted the fix/click-enforce-underscore branch July 14, 2020 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants