Skip to content

Remove Python 2.7, 3.5 testing, add PyQt 5#524

Merged
jvkersch merged 14 commits into
masterfrom
maint/remove-python-27-testing
Jul 14, 2020
Merged

Remove Python 2.7, 3.5 testing, add PyQt 5#524
jvkersch merged 14 commits into
masterfrom
maint/remove-python-27-testing

Conversation

@jvkersch
Copy link
Copy Markdown
Contributor

as it says on the tin.

Note: this means that we effectively don't test with wxpython and pyside any more.

@rahulporuri Do you know of any other toolkits that are supported under Python 3.6?

@jvkersch jvkersch requested a review from rahulporuri July 13, 2020 11:53
@corranwebster
Copy link
Copy Markdown
Contributor

You should be able to get things to run with pip-installed pyside2, with a bit of luck. Have a look at the TraitsUI and Pyface etstools.py to see how we do it there.

@rahulporuri

This comment has been minimized.

Copy link
Copy Markdown
Contributor

@rahulporuri rahulporuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can make the same changes on appveyor too, right?

Comment thread ci/edmtool.py Outdated
Comment thread ci/edmtool.py Outdated
@rahulporuri

This comment has been minimized.

Comment thread .travis.yml
@rahulporuri

This comment has been minimized.

Comment thread .travis.yml Outdated
Comment thread ci/edmtool.py Outdated
Copy link
Copy Markdown
Contributor

@rahulporuri rahulporuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jvkersch
Copy link
Copy Markdown
Contributor Author

@rahulporuri Thanks for the quick turnaround on reviewing. I think this now works, care to give it a final look? I had to make one non-trivial change for pyside2: under pyside2, instantiating a QFrame with a keyword argument size does not work. The workaround is to omit the size argument, and to resize the window afterwards. You can see the original failure with the following code snippet:

from pyface.qt import QtCore, QtGui
app = QtGui.QApplication([])
size = QtCore.QSize(10, 10)
f = QtGui.QFrame(size=size)  # complains about missing setSize method

The commit history is cluttered, so we should merge this with squash-merge.

@jvkersch
Copy link
Copy Markdown
Contributor Author

Ha, you beat me to it :)

@jvkersch jvkersch merged commit 0e470c7 into master Jul 14, 2020
@rahulporuri
Copy link
Copy Markdown
Contributor

yep yep I wasn't sure why QFrame.setSize doesn't exist on PySide2 but exists on PyQt5. I didn't look closely enough at the PyQt5 docs but the PySide2 docs for QFrame didn't mention any setSize

@jvkersch jvkersch deleted the maint/remove-python-27-testing branch July 14, 2020 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants