Add source click option used on cron jobs to install ets packages from source#532
Merged
Conversation
…nd adding to dependencies list
rahulporuri
approved these changes
Oct 27, 2020
Contributor
rahulporuri
left a comment
rahulporuri
left a comment
There was a problem hiding this comment.
LGTM. Can you do the set TRAVIS_EVENT_TYPE env var in CI like with the other PRs to exercise the cron job code path in CI? I tested this locally and it works as expected.
Contributor
|
I'm a little surprised at the fact that the CI passed without needing enable from master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #522
This PR adds a
--sourceclick option and uses this option on cron jobs to install other ets packages from source.Note that previously enable was installed from source always and that was how traits, traitsui and pyface got installed. Following Marks comment here: enthought/envisage#325 (comment), I added all of these to
__requires__in__init__.py. Additionally, I made it so that by default enable is not installed from source, but it will be when the--sourceflag is used.This follows what is done in other ets projects (e.g https://github.com/enthought/envisage/blob/8245931f7e3dfcb6513bfb7dc2ae9b10ca6f89a1/etstool.py#L255-L273)