Use PySide2 from EDM instead of PyPI and Use the latest EDM version (3.0.1)#538
Merged
Conversation
Contributor
Author
|
Appveyor is failing with Im guessing this is because the edm version is 2.0.0 in the appveyor.yml file. |
aaronayres35
changed the title
rahulporuri
approved these changes
Oct 29, 2020
Contributor
rahulporuri
left a comment
rahulporuri
left a comment
There was a problem hiding this comment.
LGTM. I went through the CI logs to make sure that there was no funny business with pyside2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #536
Also fixes #527
In this PR we try to install pyside2 from edm instead of pip. In order to do so, we need to use the latest version of edm in CI, so those version numbers are bumped as well.
In retrospect these should've been two separate PRs (shame!) and if a reviewer would prefer I am happy to go back and split them. Initially I was just trying to fix 536 without realizing it required a fix for 527.