Skip to content

Handle index=None in ScatterInspector#540

Merged
notmatthancock merged 1 commit into
masterfrom
fix/scatter-inspector-deselect
Nov 13, 2020
Merged

Handle index=None in ScatterInspector#540
notmatthancock merged 1 commit into
masterfrom
fix/scatter-inspector-deselect

Conversation

@notmatthancock
Copy link
Copy Markdown
Contributor

@notmatthancock notmatthancock commented Nov 12, 2020

Closes #26

corranwebster
corranwebster approved these changes Nov 13, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@corranwebster corranwebster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rahulporuri
Copy link
Copy Markdown
Contributor

rahulporuri commented Nov 13, 2020

Thanks for the fix @notmatthancock . Do you need a bugfix release of chaco to make use of this in the near future (within a month)?

@notmatthancock
Copy link
Copy Markdown
Contributor Author

notmatthancock commented Nov 13, 2020

Do you need a bugfix release of chaco to make use of this in the near future (within a month)?

Sure. We're working around it, but we could remove our workaround code with a release.

@notmatthancock notmatthancock merged commit b8bd324 into master Nov 13, 2020
@notmatthancock notmatthancock deleted the fix/scatter-inspector-deselect branch November 13, 2020 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@corranwebster corranwebster corranwebster approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ScatterInspector does not deselect all on index == None

3 participants

@notmatthancock @rahulporuri @corranwebster