Remove use of six and __future__ imports#554
Conversation
rahulporuri
left a comment
rahulporuri
left a comment
There was a problem hiding this comment.
I want to take a second look at the changes from sm.zip to zip. Some of them feel off and I don't trust the test suite to catch all potential issues.
| label="Main"), | ||
| Group( | ||
| Item("tick_color", label="Color", style="custom"), | ||
| #editor=EnableRGBAColorEditor()), |
There was a problem hiding this comment.
i'm happy when dead code is removed - but it'd be nice to mention this in the PR description.
I was following here: https://six.readthedocs.io/ |
| return [0, 0] | ||
|
|
||
| plot_names, visible_plots = list(sm.map(list, sm.zip(*sorted(self.plots.items())))) | ||
| plot_names, visible_plots = list(map(list, zip(*sorted(self.plots.items())))) |
There was a problem hiding this comment.
I'm not a big fan of such code - list(map(list, zip(*sorted(self.plots.items())))) - because i find it hard to understand. Anyway, that's not an actionable item in this PR given the lack of context.
There was a problem hiding this comment.
I agree, any code with ")))))" smells a bit, but that is a problem for another day/PR
2 participants
Part of #483
This PR removes all use of
sixand also removes all__future__imports (only imports were forwith_statement,print_function, andabsolute_import).It also drive by removes a few lines of commented out code