Skip to content

Run black on the codebase#599

Merged
aaronayres35 merged 7 commits into
masterfrom
black-codebase
Apr 5, 2021
Merged

Run black on the codebase#599
aaronayres35 merged 7 commits into
masterfrom
black-codebase

Conversation

@aaronayres35
Copy link
Copy Markdown
Contributor

@aaronayres35 aaronayres35 commented Apr 2, 2021

A first step towards having a flake8 clean codebase

commands run:

black chaco
black examples
black chaco -l 79
black examples -l 79

@aaronayres35 aaronayres35 mentioned this pull request Apr 2, 2021
Merged
@rahulporuri rahulporuri self-requested a review April 3, 2021 03:47
rahulporuri
rahulporuri reviewed Apr 3, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@rahulporuri rahulporuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have preferred it if the changes in this PR were actually in two separate PRs - one for the package and another for the examples.

Comment thread examples/user_guide/plot_types/create_plot_snapshots.py
@@ -725,5 +766,5 @@ def create_plot_types(names):
save_plot(window.container, fname)


if __name__ == '__main__':
if __name__ == "__main__":
main()
Copy link
Copy Markdown
Contributor

@rahulporuri rahulporuri Apr 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aaronayres35 looks like there already is a script to generate the chaco demo plots?

Copy link
Copy Markdown
Contributor Author

@aaronayres35 aaronayres35 Apr 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this script generates a plot for each plot type, not necessarily all the examples/demos (ie. not everything we show on the "gallerry"/"annotated examples" page). However, yes this is super useful and could likely be modified to regenerate all the demo plots

Comment thread examples/tutorials/tutorial11.py
Comment on lines -28 to -29
lplot.overlays.append(LineInspector(component=lplot,
axis="value", write_metadata=True, is_listener=True, color="blue"))
Copy link
Copy Markdown
Contributor

@rahulporuri rahulporuri Apr 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like there was a copy-paste error here. and below too.

Copy link
Copy Markdown
Contributor

@rahulporuri rahulporuri Apr 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can be handled in a separate PR

Comment thread examples/tutorials/scipy2008/custom_overlay_movetool.py
Comment thread examples/tutorials/scipy2008/connected_orientation.py
Comment thread examples/demo/advanced/asynchronous_updates.py Outdated
Comment thread examples/demo/advanced/spectrum.py Outdated
Comment thread examples/demo/vtk_example.py
Comment thread examples/demo/vtk/vtk_example.py
Comment thread examples/demo/vtk/spectrum.py
Comment thread examples/demo/vtk/cmap_scatter.py
rahulporuri
rahulporuri reviewed Apr 3, 2021
View reviewed changes
Comment thread chaco/barplot.py Outdated
Comment thread chaco/tests/test_speedups.py
Comment thread chaco/tests/test_plot.py Outdated
Comment thread chaco/tests/test_image_utils.py Outdated
Comment thread chaco/tests/test_image_utils.py Outdated
Comment thread chaco/scales/tests/test_scales.py Outdated
Comment thread chaco/scales/tests/test_scales.py Outdated
rahulporuri
rahulporuri approved these changes Apr 3, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@rahulporuri rahulporuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @aaronayres35 let's have a chat monday morning before you merge this PR.

Comment thread chaco/colormap_generators.py
Comment thread chaco/contour/setup.py

config.add_extension('contour',['*.c'],**numerix_info)
config.add_data_dir('tests')
numerix_info = config.get_info("numerix")
Copy link
Copy Markdown
Contributor

@rahulporuri rahulporuri Apr 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i have no clue what numerix_info is but i suspect it's dead code.

Copy link
Copy Markdown
Contributor

@rahulporuri rahulporuri Apr 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it doesn't looks like it is but im not what it does.

Comment thread chaco/contour_line_plot.py Outdated
Comment thread chaco/contour_poly_plot.py Outdated
Comment thread chaco/data_frame_plot_data.py Outdated
Comment thread chaco/multi_line_plot.py Outdated
Comment thread chaco/lineplot.py Outdated
Comment thread chaco/legend.py
"bounds_items",
"label_at_top",
):
self._layout_needed = True
Copy link
Copy Markdown
Contributor

@rahulporuri rahulporuri Apr 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here's another fun little trait which seems to have a trait change handler hooked up somewhere which redraws or something when it is set.

Comment thread chaco/layers/svg_range_selection_overlay.py Outdated
Comment thread chaco/layers/svg_range_selection_overlay.py Outdated
aaronayres35 and others added 4 commits April 5, 2021 05:47
@aaronayres35
Update examples/demo/advanced/asynchronous_updates.py
b5833f2 
Co-authored-by: Poruri Sai Rahul <rporuri@enthought.com>
@aaronayres35
Apply suggestions from code review
40f40f0 
Co-authored-by: Poruri Sai Rahul <rporuri@enthought.com>
@aaronayres35
Update chaco/lineplot.py
fd8f2b4 
Co-authored-by: Poruri Sai Rahul <rporuri@enthought.com>
@aaronayres35
more suggested changes, but watching line length
a6befa2
@aaronayres35 aaronayres35 merged commit e9af395 into master Apr 5, 2021
@aaronayres35 aaronayres35 deleted the black-codebase branch April 5, 2021 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rahulporuri rahulporuri rahulporuri approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aaronayres35 @rahulporuri