Use requires_redraw when possible#626
Merged
Merged
Conversation
aaronayres35
commented
Apr 8, 2021
Comment on lines
-436
to
-439
| def _alpha_changed(self): | ||
| self.invalidate_draw() | ||
| self.request_redraw() | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Note alpha has required_redraw=True on he base class BaseXYPlot from #585
See comment: #585 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part of #595
This PR uses the new
requires_redrawmetadata on a fewPlotComponentsubclasses.This covers the simplest cases for where
requires_redrawcan be used. There are other scenarios where it may be useful but would require doing something a bit differently. I will leave those decisions / changes for a later PR