Skip to content

Dont use traitsui.api as tui#634

Merged
aaronayres35 merged 1 commit into
masterfrom
remove-tui
Apr 8, 2021
Merged

Dont use traitsui.api as tui#634
aaronayres35 merged 1 commit into
masterfrom
remove-tui

Conversation

@aaronayres35
Copy link
Copy Markdown
Contributor

fixes #611

This PR simply imports the needed objects from traitsui.api rather than importing the whole thing as tui.

As a side note, this module is based around Workbench which has been deprecated in favor of tasks. Perhaps we want to rewrite this module? Or deprecate, or remove it... 🤔

@aaronayres35 aaronayres35 requested a review from rahulporuri April 8, 2021 12:07
Copy link
Copy Markdown
Contributor

@rahulporuri rahulporuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm on board with removing it entirely but let's do later, after we've discussed it with the rest of the folks.

@aaronayres35 aaronayres35 merged commit 4b4b648 into master Apr 8, 2021
@aaronayres35 aaronayres35 deleted the remove-tui branch April 8, 2021 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dont use traitsui.api as tui

2 participants