Import version from installed package if the file doesnt exist#644
Merged
Conversation
If the package is installed in a non-editable way, the file won't exist in the location we think it exists - so we need to fall back to importing the version information directly from the installed package modified: docs/source/conf.py
aaronayres35
approved these changes
Apr 12, 2021
Contributor
aaronayres35
left a comment
aaronayres35
left a comment
There was a problem hiding this comment.
LGTM
just one comment about using chaco instead of enable.
Co-authored-by: aaronayres35 <36972686+aaronayres35@users.noreply.github.com>
Contributor
Author
|
sigh. thanks for catching that silly silly mistake |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the package is installed in a non-editable way, the
_versionfile won't exist where we expect it to. This PR updates the sphinx configuration to get the version information from the package directly if the file doesn't exist.