Skip to content

Update api module docstring for chaco.api#665

Merged
aaronayres35 merged 6 commits into
masterfrom
update-api-module-docstring
Apr 15, 2021
Merged

Update api module docstring for chaco.api#665
aaronayres35 merged 6 commits into
masterfrom
update-api-module-docstring

Conversation

@aaronayres35
Copy link
Copy Markdown
Contributor

Follow up to #649

This PR populates and move the colormap section to the bottom of the module (although this move may have been unnecessary as I had failed to notice the all previously)
It also moves BandedMapper into the mappers section and ColormappedSelectionOverlay into the visual components section

Comment thread chaco/api.py Outdated
Copy link
Copy Markdown
Contributor

@rahulporuri rahulporuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a small comment.

Comment thread chaco/api.py
Copy link
Copy Markdown
Contributor

@rahulporuri rahulporuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM

@aaronayres35
Copy link
Copy Markdown
Contributor Author

This test failure has returned...

======================================================================
ERROR: test_dont_crash_on_click (chaco.tests.test_plot.TestEmptyPlot)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "D:\a\chaco\chaco\.edm\envs\chaco-test-3.6-pyqt\lib\site-packages\chaco\tests\test_plot.py", line 134, in test_dont_crash_on_click
    [(1, 1), (2, 2), (3, 3), (4, 4)],
  File "D:\a\chaco\chaco\.edm\envs\chaco-test-3.6-pyqt\lib\contextlib.py", line 88, in __exit__
    next(self.gen)
  File "D:\a\chaco\chaco\.edm\envs\chaco-test-3.6-pyqt\lib\site-packages\traitsui\testing\tester\ui_tester.py", line 106, in create_ui
    process_cascade_events()
  File "D:\a\chaco\chaco\.edm\envs\chaco-test-3.6-pyqt\lib\contextlib.py", line 88, in __exit__
    next(self.gen)
  File "D:\a\chaco\chaco\.edm\envs\chaco-test-3.6-pyqt\lib\site-packages\traitsui\testing\_exception_handling.py", line 74, in reraise_exceptions
    raise RuntimeError(msg)
RuntimeError: Uncaught exceptions found.
=== Exception (type: <class 'AttributeError'>, value: '_QtWindow' object has no attribute 'handler') ===
Traceback (most recent call last):
  File "D:\a\chaco\chaco\.edm\envs\chaco-test-3.6-pyqt\lib\site-packages\enable\qt4\base_window.py", line 258, in leaveEvent
    self.handler.leaveEvent(event)
AttributeError: '_QtWindow' object has no attribute 'handler'

----------------------------------------------------------------------

I had thought it was consistently occurring, so when it didn't happen on #663 (and on any commits since then...) I had assumed that fixed it.

Looks like this is really an intermittent failure and will require more investigation.

I am tempted to just skip the test on windows/pyqt for now until it can truly be resolved so it doesn't interfere with other PRs. Will do this in a separate PR.

@aaronayres35 aaronayres35 merged commit f4fe0e3 into master Apr 15, 2021
@rahulporuri rahulporuri deleted the update-api-module-docstring branch April 16, 2021 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants