Skip to content

Delete the quickstart page from the docs#668

Merged
aaronayres35 merged 1 commit into
masterfrom
doc/remove-quickstart
Apr 16, 2021
Merged

Delete the quickstart page from the docs#668
aaronayres35 merged 1 commit into
masterfrom
doc/remove-quickstart

Conversation

@aaronayres35
Copy link
Copy Markdown
Contributor

Somewhat of a follow up to #667

Without chaco.shell, the remaining content on this page is redundant and not needed. So, in this PR the page is removed entirely.

Comment on lines -106 to -107
First plots from IPython
------------------------
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm not so sure about this PR. Why not just remove this "First plots from IPython" section instead? It's the only shell specific content that I see in this page.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we had discussed this while we went through the docs. The other sections were all redundant from the tutorial / I had "kill quickstart" written in my notes from our discussion.

I had this removal in a separate PR specifically because it wasn't only motivated by the removal of chaco.shell

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry. you're right. i was mistaking this page for something else. approving.

Copy link
Copy Markdown
Contributor

@rahulporuri rahulporuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The users already run into the sample plot gallery and/or the interactive plotting tutorial so there isnt much point in this page

@rahulporuri
Copy link
Copy Markdown
Contributor

rahulporuri commented Apr 16, 2021

@aaronayres35 can you hold off on this until we have a chat in 30 mins? Im sorry for flip-flopping

@aaronayres35 aaronayres35 merged commit f26a5cb into master Apr 16, 2021
@aaronayres35 aaronayres35 deleted the doc/remove-quickstart branch April 16, 2021 13:42
rahulporuri pushed a commit that referenced this pull request Apr 22, 2021
the quickstart page got removed in #668

	deleted:    docs/source/images/lines.png
	deleted:    docs/source/images/lines_final.png
	deleted:    docs/source/images/mylineplot.png
	deleted:    docs/source/images/simple_line.png
	deleted:    docs/source/user_manual/images/simple_line.png
rahulporuri pushed a commit that referenced this pull request Apr 22, 2021
* CLN : Remove chaco.shell related images from docs

the doc page which used these images was removed in the PR #669
but we forgot to remove the images in the PR

	deleted:    docs/source/user_manual/images/ipython_basic.png
	deleted:    docs/source/user_manual/images/ipython_kde.png
	deleted:    docs/source/user_manual/images/ipython_multi.png

* CLN : Remove images from quickstart page which got removed

the quickstart page got removed in #668

	deleted:    docs/source/images/lines.png
	deleted:    docs/source/images/lines_final.png
	deleted:    docs/source/images/mylineplot.png
	deleted:    docs/source/images/simple_line.png
	deleted:    docs/source/user_manual/images/simple_line.png

* CLN : Remove another copy of simple_line

and just use the one image everywhere needed in docs

	modified:   docs/source/user_manual/annotated_examples.rst
	deleted:    docs/source/user_manual/example_images/simple_line.png

* CLN : I am not even sure what the xcf file is

but it isnt used in the docs so lets remove it

	deleted:    docs/source/images/chaco_show.xcf

* FIX : Dont delete all copies of simple_line

and use the one copy everywhere

	new file:   docs/source/images/simple_line.png
	modified:   docs/source/user_manual/annotated_examples.rst
	modified:   docs/source/user_manual/chaco_tutorial.rst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants