Remove objects/modules which explicitly raised a deprecation warning#670
Merged
Conversation
This reverts commit e4818c8.
aaronayres35
commented
Apr 15, 2021
12 tasks
rahulporuri
approved these changes
Apr 16, 2021
Contributor
rahulporuri
left a comment
rahulporuri
left a comment
There was a problem hiding this comment.
LGTM with a couple of comments/questions
| @@ -1,649 +0,0 @@ | |||
| """ Defines the SimpleZoom class. | |||
Contributor
There was a problem hiding this comment.
looks like this too was moved into enable as the viewport zoom tool and modified.
When we do the release, i think it will be good to highlight the fact that there are classes in enable which can be used by end users if they can't migrate to the chaco ZoomTool immediately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #580
Also part of #438
This PR removes deprecated modules/classes which explicitly raised a deprecation warning. There are others in which we simply have comments saying things are deprecated. Perhaps those can be removed entirely, or we should start issuing warnings. They can be handled in a separate PR.