Import color palette from chaco.api directly#675
Merged
rahulporuri merged 2 commits intoApr 16, 2021
Conversation
added 2 commits
April 16, 2021 15:50
this was an autoamted search and replace
aaronayres35
approved these changes
Apr 16, 2021
Contributor
aaronayres35
left a comment
aaronayres35
left a comment
There was a problem hiding this comment.
LGTM
Eventually when we flake8 clean everything we will want imports in alphabetical order but that can be dealt with in a later PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of the examples import
cbrewerfromchaco.apiasCOLOR_PALETTEfromchaco.example_support. I am not surechaco.example_supportshould be a public module and I don't think we should be promoting this usage. This PR replaces all instances offrom chaco.example_support import COLOR_PALETTEwithfrom chaco.api import cbrewer as COLOR_PALETTE.