Fix a couple of demos#676
Merged
Merged
Conversation
added 2 commits
April 16, 2021 16:06
previously we were listening to the non-existent "data" trait which should have been "value._data". Once this change is made, the multi_line_plot.py and multi_line_plot_demo.py demos work as expected and without this change, they both crash with a traits observe error modified: chaco/multi_line_plot.py
this fixes the javascript hover tools advanced example modified: examples/demo/advanced/javascript_hover_tools.py
aaronayres35
approved these changes
Apr 16, 2021
Contributor
aaronayres35
left a comment
aaronayres35
left a comment
There was a problem hiding this comment.
LGTM
All the demos launch without errors and work as expected now.
I ran the javascript_hover_tools.py and my browser did not immediately launch, but I was able to open the html file manually and things seemed to be working
Contributor
Author
Hmm. Weird. The browser opened up for me as soon the script finished running. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
multi_line_plot.pymulti_line_plot_demo.pyjavascript_hover_tools.pyThe first two were failing earlier because of a bad listener hookup. The latter was failing because of the use of non-existent methods.