Move tests in "tests_with_backend" submodule into "tests" submodule#683
Merged
Conversation
added 3 commits
April 19, 2021 15:53
and remove the now empty tests_with_backend module renamed: chaco/tests_with_backend/test_2d_case.py -> chaco/tests/test_2d_case.py renamed: chaco/tests_with_backend/test_highlight_tool.py -> chaco/tests/test_highlight_tool.py deleted: chaco/tests_with_backend/__init__.py
modified: chaco/tests/test_2d_case.py modified: tox.ini
deleted: chaco/tests/README.txt deleted: chaco/tests_with_backend/README.txt
added 4 commits
April 20, 2021 12:16
…ests-with-backend-submodule
previously it was only being skipped on windows/qt4 modified: chaco/tests/test_plot.py
modified: chaco/tests/test_image_plot.py
Contributor
|
Still LGTM, I'll have to look more into the failing tests :/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves the tests in
chaco.tests_with_backendsubmodule intochaco.testssubmodule. This PR also removes a couple of unnecessaryREADME.txtfile. Finally, this PR also fixes flake8 errors in one of the tests which got moved.