Remove PlotFrames#692
Merged
Merged
Conversation
12 tasks
rahulporuri
suggested changes
Apr 20, 2021
Contributor
rahulporuri
left a comment
rahulporuri
left a comment
There was a problem hiding this comment.
I would just remove them outright. I don't think it's worth deprecating them now and waiting for another rleease to remove them. I'll check if there are any users of the plot frame classes.
Contributor
|
I think it's safe to remove them outright. I only found one meaningful/new-ish use of |
Contributor
|
They can be removed outright I think - they have been superseded by the various plot layout classes. |
aaronayres35
commented
Apr 20, 2021
| above a single plot area, which is an OverlayPlotContainer. (The GeoTrack class | ||
| is actually a subclass of VPlotContainer that automatically create GeoAxis objects | ||
| as GeoPlots are added to the plot area.) | ||
|
|
Contributor
Author
There was a problem hiding this comment.
There are other .txt files like this in the docs directory but they aren't actually a part of the documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #580
This PR adds removes the various plot frame classes from the code base.
Unfortunately, since these objects are exposed inchaco.apinow just importing from chaco.api will raise a deprecation warning...Perhaps these warnings should be raised when instantiating a plot frame object?Edit: I moved the warnings to occur inside the__init__methods and updated the tests.