Cleanup ci module and setup#695
Merged
Merged
Conversation
added 2 commits
April 20, 2021 12:43
modified: ci/edmtool.py modified: ci/requirements.txt modified: setup.py modified: tox.ini deleted: travis-ci-requirements.txt
modified: tox.ini
aaronayres35
approved these changes
Apr 20, 2021
Comment on lines
-3
to
-4
| pillow | ||
| git+http://github.com/nucleic/kiwi.git#egg=kiwi |
Contributor
There was a problem hiding this comment.
This file looks like it was unused, but I don't see these anywhere else explicitly. Im assuming they come from enable, and so don't need to be listed as deps
Contributor
Author
There was a problem hiding this comment.
not sure where these came from. i didn't bother looking for when this was added to the repo. but you're probably right - they were possible needed for source installs of enable, which are handled by the ci module now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes a number of changes to the ci module and setup script
use_2to3in setup scriptcoveragefrom requirements file to edmtool so it can be installed via edm instead of pypitravis-ci-requirements.txt