Fix potentially buggy calls to "super"#706
Merged
Merged
Conversation
rahulporuri
changed the title
replace use of super by manually calling setUp with self on the class the test case inherits from
rahulporuri
commented
Apr 21, 2021
rahulporuri
changed the title
aaronayres35
approved these changes
Apr 21, 2021
Contributor
aaronayres35
left a comment
aaronayres35
left a comment
There was a problem hiding this comment.
LGTM just one question
| values = np.arange(4).reshape(2, 2) | ||
| self.plot = create_image_plot(values) | ||
| super(TestImageInspectorToolGray, self).setUp() | ||
| BaseImageInspectorTool.setUp(self) |
Contributor
There was a problem hiding this comment.
Why exactly can't this be super().setUp()? I notice the tests all still pass if that change is made.
Contributor
Author
There was a problem hiding this comment.
we discussed this in person - this is part convention and part best practice afaik - especially because we have a few places where we need to call setUp on more than one baseclass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.